[REVIEW] Reviewing implementation - Githubissues

cap-js / audit-logging

CDS plugin providing integration to the SAP Audit Log service as well as out-of-the-box personal data-related audit logging based on annotations.

https://cap.cloud.sap/docs/guides/data-privacy

Apache License 2.0

4 stars 1 forks source link

[REVIEW] Reviewing implementation #7

Closed danjoa closed 1 year ago

danjoa commented 1 year ago

DON'T MERGE YET

→ let's use this for a joint review

collection of TODOs: https://github.com/cap-js/audit-logging/issues/3
capire:
- https://github.com/cap-js/docs/pull/261
- https://github.tools.sap/cap/docs/pull/253

to decide/ do before release of 0.1.0

[x] data structure
[x] api (no compat?)
[x] fix emit
~[ ] check logs in fiori tests (see comments "// TODO: check if this is correct")~ -> https://github.com/cap-js/audit-logging/issues/10
~[ ] tests with @cap-js/sqlite~ -> https://github.com/cap-js/audit-logging/issues/9
~[ ] finalize docs~ -> in progress. not tracked here.
[x] support standard and oauth2 plan
[x] end2end oauth2!!!
ANYTHING ELSE?!

optional

[x] persistent outbox + oauth2 plan, should be solvable when accessing API without client lib
~[ ] provider audit logs?~ -> currently in discussion, follow-ups as needed

sjvans commented 1 year ago

review decisions applied in https://github.com/cap-js/audit-logging/pull/8