search

cap-js / cds-dbs

Monorepo for SQL Database Services for CAP
https://cap.cloud.sap/docs/
Apache License 2.0
32 stars 9 forks source link

fix: iso function creation #685

Closed johannes-vogel closed 3 weeks ago

johannes-vogel commented 3 weeks ago

I've verified with this implementation that the creation of ISO function works during productive deployment. However, the connection creation at runtime did not work because of the dynamic creation of the function at runtime. We should move that to the tests until there's a mechanism to hook into plain sql deployment.

@BobdenOs Could you check whether my change for test deployments is sufficient?

johannes-vogel commented 3 weeks ago

I just checked the remaining failures and this is due to compliance create test suite to set _deployed to true which skips the ISO function generation.

BobdenOs commented 3 weeks ago

@johannes-vogel I will add a check that makes sure that the ISO function is deployed or not. If not it will be excluded from the input converters. I am currently adjusting the Timestamp and DateTime test data.