cap-js / cds-dbs

Monorepo for SQL Database Services for CAP
https://cap.cloud.sap/docs/
Apache License 2.0
32 stars 9 forks source link

chore: coercify decimals expects #697

Open sjvans opened 2 weeks ago

BobdenOs commented 2 weeks ago

@David-Kunz Does this test need to check all the results that are coming back? I see some of these properties are commented out. Would be nice if the test only has the properties which it is testing.

David-Kunz commented 1 week ago

@BobdenOs , the tests are indeed testing a bit too much, I don't think there's a need to test all properties. We could certainly remove some of those in the $select clause. It's only important that the $select clause is 1) taken into account and 2) properly handles draft properties. "Normal" properties don't need to be checked extensively.

@sjvans, your PR is fine for me, alternatively you can just skip testing those fields, up to you.