Closed stockbal closed 2 weeks ago
Hi Ludwig,
looks great! I'm just unsure about instance methods, which are not explicitly mentioned in the changelog. I.e., today the types allow us to do:
new SELECT(…).columns(…)
so I guess it should be possible to do
new SELECT(…).localized(…)
etc. as well. @mariayord do you happen to know about this or could you please forward this question to a runtime maintainer familiar with the matter? Thanks!
Best, Daniel
Hi @daogrady ,
The QL API should be used only with static calls, as it is documented in https://cap.cloud.sap/docs/node.js/cds-ql#select.
Best Regards Maria
Hi @mariayord ,
I see, thanks for the clarification!
Guess we should also add private constructor();
to all the query classes then. But that is beyond the scope of this PR and I will take care of that[^1].
@stockbal with that we should be able to merge your contribution. Thanks for handing it in!
Best, Daniel
Adds all possible variants with
localized
toSELECT
Extract from
@sap/cds/lib/ql/SELECT.js
Closes #257