search

cap-js / change-tracking

CDS plugin providing out-of-the box support for automatic capturing, storing, and viewing of the change records of modeled entities.
https://cap.cloud.sap/docs
Apache License 2.0
20 stars 8 forks source link

Add limitations about CAP Feature toggles to the documentation / readme #120

Closed FrankVisuals closed 2 weeks ago

FrankVisuals commented 1 month ago

As discussed in issue 116.

I think it's worth to add this to the readme, as it cost us quite some time to find this.

FrankVisuals commented 1 month ago

@Sv7enNowitzki (random ping because I saw you merged last) any feedback on this?

nkaputnik commented 1 month ago

Hello Frank, I will be modifying your PR before we merge it. In essence, we have annotation flags to disable the automatic addition of the change view onto the model, as well as the facet, so the solution is actually even simpler than what you propose.

It will just take a couple of days because of my other, regular workload.

Best, Nick

From: Frank Hufnagel @.> Sent: Friday, September 27, 2024 9:32:09 AM To: cap-js/change-tracking @.> Cc: Subscribed @.***> Subject: Re: [cap-js/change-tracking] Add limitations about CAP Feature toggles to the documentation / readme (PR #120)

@Sv7enNowitzkihttps://github.com/Sv7enNowitzki (random ping because I saw you merged last) any feedback on this?

— Reply to this email directly, view it on GitHubhttps://github.com/cap-js/change-tracking/pull/120#issuecomment-2378601520, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AD2JLF5QHIK6Q5TTCE55UFLZYUCXTAVCNFSM6AAAAABONIBBZKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGNZYGYYDCNJSGA. You are receiving this because you are subscribed to this thread.Message ID: @.***>

FrankVisuals commented 1 month ago

Thanks for the reply. Actually, I think my proposal is part of the solution that you describe. When disabling the UI facet creation + the creation of the association you have to create the association yourself (even though then you can name it "changes").

nkaputnik commented 1 month ago

Exactly, then you can name it changes.

Best, Nick

From: Frank Hufnagel @.> Date: Friday, 27. September 2024 at 10:36 To: cap-js/change-tracking @.> Cc: Josipovic, Nikica @.>, Comment @.> Subject: Re: [cap-js/change-tracking] Add limitations about CAP Feature toggles to the documentation / readme (PR #120)

Thanks for the reply. Actually, I think my proposal is part of the solution that you describe. When disabling the UI facet creation + the creation of the association you have to create the association yourself (even though then you can name it "changes").

— Reply to this email directly, view it on GitHubhttps://github.com/cap-js/change-tracking/pull/120#issuecomment-2378751352, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AD2JLFZPNKMOECEM5IJZCYDZYUKHJAVCNFSM6AAAAABONIBBZKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGNZYG42TCMZVGI. You are receiving this because you commented.Message ID: @.***>