search

cap-js / ord

Open Resource Discovery (ORD) is a protocol that allows applications and services to self-describe their exposed resources and capabilities. This plugin enables generation of ORD document for CAP based applications.
Apache License 2.0
3 stars 4 forks source link

Support for multiple protocols #17

Closed muskansethi1 closed 5 months ago

muskansethi1 commented 6 months ago
  1. Multiple entries for apiResources depending on protocols
  2. No apiProtocol support in ord extensions
RoshniNaveenaS commented 6 months ago

Currently for the case of apiProtocol being rest , the metadata validator throws an error saying :

sap-ord-api-resource-definition-type OData definitions only accept apiProtocol odata-v2 or odata-v4 in their parent resource. Instead the parent resource got apiProtocol: rest.

muskansethi1 commented 5 months ago

discussion with Simon ->

the json apiResource for rest protocol would only generate openapi ( and not edmx). For odata-v4 it would still be both. So this change is to be done.

will pick up this change @RoshniNaveenaS What should be done for graphql?

RoshniNaveenaS commented 5 months ago

discussion with Simon -> the json apiResource for rest protocol would only generate openapi ( and not edmx). For odata-v4 it would still be both. So this change is to be done.

will pick up this change @RoshniNaveenaS What should be done for graphql?

We don't support graphql for ORD. We will ignore with a warning

RoshniNaveenaS commented 5 months ago

Hello @muskansethi1 , The PR looks good! Can you please resolve the conflicts ?

muskansethi1 commented 5 months ago

Hello @muskansethi1 , The PR looks good! Can you please resolve the conflicts ?

Resolved