cap-js / telemetry

CDS plugin providing observability features, incl. automatic OpenTelemetry instrumentation.
https://cap.cloud.sap/docs
Apache License 2.0
7 stars 5 forks source link

Adding Cloud Logging Service instance creation and binding to service as part of mta using cds add mta #146

Open gopalanand333 opened 2 months ago

gopalanand333 commented 2 months ago

Hi, Currently if we want to deploy application to the cloud foundry runtime + cloud logging service, we need to manually add the service instance configuration and binding to srv. This does leads to error if someone miss configures the ingest configuration.

     - name: incidents-cloud-logging  
       type: org.cloudfoundry.managed-service  
       parameters: 
         service: cloud-logging  
         service-plan: standard  
         config:
          ingest_otlp: 
            enabled: true 

steps defined here: https://github.com/SAP-samples/btp-developer-guide-cap/blob/main/documentation/observability/4-deploy-to-cf.md#set-up-the-sap-cloud-logging-service. If cds add mta or adding the telemetry plugin can add the configuration to mta automatically, It will improve user experience and avoid any chances of error due to miss configured mta.

sjvans commented 2 months ago

hi @swaldmann

can plugins provide content for mtas?

swaldmann commented 2 months ago

Yes, but that's currently in undocumented Alpha. I'm currently working on the cds.add docs though, so might be out in time for the 7.9 release.

I created #149 to play around with it, which already works with latest cds-dk.