capablevms / CHERI-ELF-comp

Other
4 stars 1 forks source link

Add a new test #12

Closed 0152la closed 11 months ago

0152la commented 1 year ago
ltratt commented 1 year ago

OK with me. I'll hand over to @jacobbramley .

jacobbramley commented 12 months ago

LGTM, please squash.

0152la commented 12 months ago

Squashed.

ltratt commented 12 months ago

bors r+

bors[bot] commented 12 months ago

Build failed:

0152la commented 12 months ago

bors try

bors[bot] commented 12 months ago

try

Build failed:

0152la commented 11 months ago

bors try

bors[bot] commented 11 months ago

try

Build failed:

0152la commented 11 months ago

bors try

bors[bot] commented 11 months ago

try

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here. For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

0152la commented 11 months ago

Ready for review.

I made a mistake reading the logs - the error was not withing the QEMU instance, but rather launching it. So I assume they just added a libpng dependency. I've updated the CI Docker image locally (just one line), and I'll be opening a PR for that as well.

0152la commented 11 months ago

GitHub can't show me what's changed, but most of the diff is the CMake stuff, which I'm not very familiar with.

The review request should've only been on the one commit after the failed merge attempt, which only had the one include added - https://github.com/capablevms/CHERI-ELF-comp/pull/12/commits/11bc7660a06c3b0f3c4884bcdb9fd45143311834.

ltratt commented 11 months ago

Please squash.

0152la commented 11 months ago

Squashed.

ltratt commented 11 months ago

bors r+

bors[bot] commented 11 months ago

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here. For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.