Closed 0152la closed 11 months ago
OK with me. I'll hand over to @jacobbramley .
LGTM, please squash.
Squashed.
bors r+
Build failed:
bors try
bors try
bors try
Build succeeded!
The publicly hosted instance of bors-ng is deprecated and will go away soon.
If you want to self-host your own instance, instructions are here. For more help, visit the forum.
If you want to switch to GitHub's built-in merge queue, visit their help page.
Ready for review.
I made a mistake reading the logs - the error was not withing the QEMU instance, but rather launching it. So I assume they just added a libpng
dependency. I've updated the CI Docker image locally (just one line), and I'll be opening a PR for that as well.
GitHub can't show me what's changed, but most of the diff is the CMake stuff, which I'm not very familiar with.
The review request should've only been on the one commit after the failed merge attempt, which only had the one include added - https://github.com/capablevms/CHERI-ELF-comp/pull/12/commits/11bc7660a06c3b0f3c4884bcdb9fd45143311834.
Please squash.
Squashed.
bors r+
Build succeeded!
The publicly hosted instance of bors-ng is deprecated and will go away soon.
If you want to self-host your own instance, instructions are here. For more help, visit the forum.
If you want to switch to GitHub's built-in merge queue, visit their help page.
tests
CMakeFile. Now it's easier to write how tests will be ran, without a bunch of in-built inferenceddc_overwrite
, which attempts to break the DDC compartmentalizatin approach by temporarily using the PCC as the DDC to access a secret