capablevms / CHERI-ELF-comp

Other
4 stars 1 forks source link

Internal `malloc` and various improvements #27

Closed 0152la closed 5 months ago

0152la commented 6 months ago

Since this has quite a bit of changes, including lots of removals, I decided to open the PR as multiple commits, to make reviewing easier.

ltratt commented 6 months ago

Somehow I missed this one -- sorry!

ltratt commented 6 months ago

https://github.com/capablevms/CHERI-ELF-comp/pull/27/commits/bd730889c5f622ccedaf4ee0f2625732405dfc21 says "Remove some currently not working tests" but it adds two tests and removes none?

0152la commented 6 months ago

bd73088 says "Remove some currently not working tests" but it adds two tests and removes none?

I think I forgot to add CMakeLists.txt in that commit, and that got added in 06b708a.

ltratt commented 6 months ago

Please squash.

0152la commented 6 months ago

Squashed.

ltratt commented 5 months ago

@0152la I guess the new commit fixes things and this can be squashed? If so, please squash.

0152la commented 5 months ago

I wanted to do a bit further testing before going forward with this PR, in case anything else slipped through the cracks. I'll either squash it, or push further commits, based on how it goes.

0152la commented 5 months ago

Ready for review.

ltratt commented 5 months ago

Please squash.

0152la commented 5 months ago

Squashed.