search

capacitor-community / admob

Community plugin for using Google AdMob
MIT License
213 stars 66 forks source link

For fixing issue #160 iOs banner overlapping content on iPhone #249

Closed looklookson closed 1 year ago

looklookson commented 1 year ago

Fixing https://github.com/capacitor-community/admob/issues/160

iOs banner overlapping content on iPhone with rounded corners iPhones with rounded corners appeared 12 sept of 2018 Since that release date iOs "view" gives a "safeAreaLayoutGuide"

distante commented 1 year ago

Also please rebase

mouadhbb commented 8 months ago

Hello @looklookson @distante,

I think we need to do a rollback for this pull request ( My PR https://github.com/capacitor-community/admob/pull/308 ) because it causes problems when we are on a Banner with a TOP_CENTER position, and it also distorts the Banner's height. I believe we should guide developers towards using a plugin like https://github.com/AlwaysLoveme/capacitor-plugin-safe-area to handle such issues in their JavaScript code rather than coding it natively. Here is also an image showing that it causes problems on iOS and, moreover, I no longer have the same behavior between Android and iOS, which is a bit bothersome. bug image file

looklookson commented 7 months ago

Hello @looklookson @distante,

I think we need to do a rollback for this pull request ( My PR #308 ) because it causes problems when we are on a Banner with a TOP_CENTER position, and it also distorts the Banner's height. I believe we should guide developers towards using a plugin like https://github.com/AlwaysLoveme/capacitor-plugin-safe-area to handle such issues in their JavaScript code rather than coding it natively. Here is also an image showing that it causes problems on iOS and, moreover, I no longer have the same behavior between Android and iOS, which is a bit bothersome. bug image file

I don't suggest to rollback this fix because some user currently use this feature. I suggest to add a option to allow user to disable this feature just in case they don't need it.