search

capacitor-community / admob

Community plugin for using Google AdMob
MIT License
205 stars 66 forks source link

Upgrade depency for GoogleAppMeasurement since it seems to block upgrading to Capacitor 5 #283

Closed basvdijk closed 8 months ago

basvdijk commented 9 months ago

Describe the bug

When updating to Capacitor 5 I got conflicts because Google-Mobile-Ads-SDK 10.1.0 is still used. This was released at 2023‑02‑16 according to https://developers.google.com/ad-manager/mobile-ads-sdk/ios/rel-notes The latest version is 10.10.0

This bug might be related to https://github.com/capacitor-community/admob/issues/255 as well

Analyzing dependencies
[!] CocoaPods could not find compatible versions for pod "GoogleAppMeasurement/WithoutAdIdSupport":
  In Podfile:
    CapacitorCommunityAdmob (from `../../node_modules/@capacitor-community/admob`) was resolved to 5.1.1, which depends on
      Google-Mobile-Ads-SDK (= 10.1.0) was resolved to 10.1.0, which depends on
        GoogleAppMeasurement (< 11.0, >= 7.0) was resolved to 10.2.0, which depends on
          GoogleAppMeasurement/AdIdSupport (= 10.2.0) was resolved to 10.2.0, which depends on
            GoogleAppMeasurement/WithoutAdIdSupport (= 10.2.0)

    CapacitorFirebaseAnalytics/AnalyticsWithoutAdIdSupport (from `../../node_modules/@capacitor-firebase/analytics`) was resolved to 5.1.0, which depends on
      FirebaseAnalytics/WithoutAdIdSupport (= 10.8.0) was resolved to 10.8.0, which depends on
        GoogleAppMeasurement/WithoutAdIdSupport (= 10.8.0)

Because this AdMob plugin is still using 10.2.0 I can't upgrade which basically blocks the app development since Capacitor 5 is out since May this year.

Expected behavior This plugin to use 10.8.0

rdlabo commented 8 months ago

Thanks for issue. This is fixed at next release: https://github.com/capacitor-community/admob/commit/795a81afb35aa1aab37e68413915440e757dd42b

Thanks!