capacitor-community / apple-sign-in

Sign in with Apple Support
MIT License
135 stars 58 forks source link

Deprecated API usage notice on Android #105

Open piotr-cz opened 4 months ago

piotr-cz commented 4 months ago

Describe the bug

When building app in Android Studio, following notice is printed in the Build tab:

> Task :capacitor-community-apple-sign-in:compileDebugJavaWithJavac
Note: XXX\node_modules\@capacitor-community\apple-sign-in\android\src\main\java\com\getcapacitor\community\applesignin\SignInWithApple.java uses or overrides a deprecated API.
Note: Recompile with -Xlint:deprecation for details.

> Task :capacitor-community-apple-sign-in:bundleLibCompileToJarDebug

To Reproduce Steps to reproduce the behavior:

  1. Integrate plugin
  2. Open Android Studio
  3. Build
  4. See notice

Expected behavior Even that Android functionality is not implemented and it's only a placeholder, it's still using deprecated methods

Screenshots Not provided

Desktop (please complete the following information): Not applicable

Smartphone (please complete the following information): Not applicable

Additional context

I'd say that the src/main/java/com/getcapacitor/community/applesignin/SignInWithApple.java file was omitted from upgrades when rest of plugin code base was upgraded to Capacitor 4 and Capacitor 5