search

capacitor-community / apple-sign-in

Sign in with Apple Support
MIT License
135 stars 58 forks source link

web version requires `scriptjs` which is not a dependency #29

Closed mesqueeb closed 3 years ago

mesqueeb commented 3 years ago

require('scriptjs') in the code, but this is no dependency. Took me a long time to find this bug 😅

jakubforman commented 3 years ago

After install plugin with npm install @capacitor-community/apple-sign-in have a problem with WEB implementation.

If I call registerWebPlugin(SignInWithApple); make error in every devices

./node_modules/@capacitor-community/apple-sign-in/dist/esm/web.js Module not found: Error: Can't resolve 'scriptjs' in '/Users/jakub_josef_forman/Development/pwa/cocktails/node_modules/@capacitor-community/apple-sign-in/dist/esm'

The problem is not in dependency as you say.

Have any hot fix for enable implementation on Web?

Implementation without using registerWebPlugin(SignInWithApple); work fine on iOS.

mesqueeb commented 3 years ago

Yes. I have the same. I tried adding the dependency but it's not enough.

WEB just doesn't work at all for me.

Now I have commented out the registerWeb line and have given up for now. I hope someone can fix it !

hatsantos commented 3 years ago

Same here... When build is --prod there's an error related to the nom existing require("scriptjs").

I don't need the web implementation, so I think if I simply add the dependency I will not have a problem.

Unfortunately the PR has not accepted and the dependency is not there.

epicshaggy commented 3 years ago

solved in #20