capacitor-community / apple-sign-in

Sign in with Apple Support
MIT License
135 stars 58 forks source link

v0.0.12 doesn't work anymore #47

Closed raykin closed 2 years ago

raykin commented 2 years ago

Describe the bug v0.0.12 can't work anymore because package.json contains dependency to latest Capacitor which points to latest released Cap3.

To Reproduce Install v0.0.12 in a fresh new app, ionic serve report compile error.

[ng] Error: node_modules/@capacitor-community/apple-sign-in/node_modules/@capacitor/core/types/definitions-internal.d.ts:16:18 - error TS2430: Interface 'CapacitorInstance' incorrectly extends interface 'CapacitorGlobal'.
[ng]   Types of property 'Plugins' are incompatible.
[ng]     Property 'SignInWithApple' is missing in type '{ [pluginName: string]: { [prop: string]: any; }; }' but required in type 'PluginRegistry'.
[ng] 16 export interface CapacitorInstance extends CapacitorGlobal {
[ng]                     ~~~~~~~~~~~~~~~~~
[ng]   node_modules/@capacitor-community/apple-sign-in/dist/esm/definitions.d.ts:3:9
[ng]     3         SignInWithApple: SignInWithApplePlugin;
[ng]               ~~~~~~~~~~~~~~~
[ng]     'SignInWithApple' is declared here.

Create a new branch to support cap2 is possible. I tried to sent a pull request but it can't work because v0.0.12 is a tag.

Screen Shot 2021-08-06 at 4 01 54 PM

selected-pixel-jameson commented 2 years ago

The same things happens with Capacitor 3 on the latest version 1.0.0.

jcesarmobile commented 2 years ago

I've published 0.2.0 that should be compatible with Capacitor 2, and 1.0.1 that should be compatible with Capacitor 3

raykin commented 2 years ago

It doesn't work. Becase 0.2.0 is now using Capacitor3 compatible code, although the dependency has fixed. Screen Shot 2021-09-20 at 10 21 59 PM