search

capacitor-community / apple-sign-in

Sign in with Apple Support
MIT License
143 stars 60 forks source link

Issue with Capacitor 2.5 and apple-sign-in 1.x #51

Closed mesqueeb closed 3 years ago

mesqueeb commented 3 years ago

I know you started work on Capacitor 3 compatibility, and you put that work on the master branch.

There is however a small issue with the way the package.json was written for this package's version 1.0.0.

image

↑ I can't install it any more on a Capacitor 2.x project...

I made a fix and want to open a PR:

image

However, the version 1.0.0 version of apple-sign-in doesn't have a branch any more, so I can't make the PR towards anything.

Please help!

jcesarmobile commented 3 years ago

I've published 0.2.0 that should be compatible with Capacitor 2, and 1.0.1 that should be compatible with Capacitor 3 Also created 0.x branch in case somebody want to make changes for Capacitor 2