Closed selected-pixel-jameson closed 2 years ago
I've tried what is posted in this issue https://github.com/capacitor-community/apple-sign-in/issues/22, but then I get the same result it's just giving me a type error saying it cannot find the @capacitor-community/apple-sign-in module.
It seems to be a distribution issue
A messy workaround:
Since we're modifying node_modules this change is easily overwritten, but it does work on my test device.
The following configuration didn't work for me, but it's closer to what we're trying to accomplish: "@capacitor-community/apple-sign-in": "github:capacitor-community/apple-sign-in"
@Valericoe Yes, this is not a production level solution. I ended up clone my own repo doing a build and then copying the dist/folder into the node_modules/@capacitor-community/apple-sign-in folder just so I could see if this even was working.
I was able to verify that it's working at least, which is a good thing. It would be very much appreciated if @mlynch or @epicshaggy or one of the other contributors would release a new version on NPM so that we can move forward.
@mlynch @rdlabo @epicshaggy All we need is a new build to be published to NPM please and thank you.
There has been a mixup of versions, latest version (0.1.2) was compatible with Capacitor 3 already, while version 1.0.0 wasn't, not sure why it was published with a major version bump 8 months ago and then continued doing patch/minor bumps from 0.x.x
I've published 1.0.1 with latest changes
@mlynch According to this issue, https://github.com/rlfrahm/capacitor-apple-login/issues/3, you forked this repo to maintain it and provide support because it's necessary. However, right now there is no way that I can get this working with Capacitor 3.
This paired with the fact that
capacitor-community/facebook-login
is no longer supporting capacitor version 2, https://github.com/capacitor-community/facebook-login/issues/63, makes it impossible for us to move forward with any kind of updates that facebook is requiring and will thus leave our authentication for any kind of app that supports third-party auth in disarray when it comes to using the capacitor framework since Apple requires you implement Apple Sign In if you implement any other third-party Auth.It looks like the updates were made in the master branch to support Cap version 3? Is this not the case? We desperately need this to support Capacitor Version 3.
I have version 1.0.0 installed, yet when I try to do an iOS Build I'm getting the following error.