search

capacitor-community / apple-sign-in

Sign in with Apple Support
MIT License
145 stars 63 forks source link

Add usePopup configuration #75

Open philipp-schaerer-lambdait opened 2 years ago

philipp-schaerer-lambdait commented 2 years ago

If someone has also got the problem that the Apple-Sign-In needs to be triggered twice while using an iOs device in the web environment, then it is probably due to a blocked popup. The error popup_blocked_by_browser is being triggered.

It would be nice to be able to set the usePopup option to false: https://github.com/capacitor-community/apple-sign-in/blob/98282774b6433db8ec29e93c4ddf21562dfae675/src/web.ts#L36-L37

There was already a pull request for this change: https://github.com/capacitor-community/apple-sign-in/pull/62

The issue should be reproduceable using the Private Mode in Safari. Edit: not sure if changing it to non-popup behavior really fixes the issue, should be tested with multiple devices

georgefam commented 2 years ago

having same issue, getting popup_blocked_by_browser

I have verified on real device and also changed safari on iPhone to allow popup and still getting same error

yllaw commented 2 years ago

I am also having this issue.

We send our web link through instagram and we try to drive users to sign up using Apple. The embedded web browser via IG will throw popup_blocked_by_browser.

This error is damaging our onboarding flow.

marclou commented 1 year ago

Same issue here

AAmeriyan commented 1 month ago

Same Here