capacitor-community / apple-sign-in

Sign in with Apple Support
MIT License
135 stars 58 forks source link

feat: remove useless cjs dependencies #91

Closed luca-peruzzo closed 1 month ago

luca-peruzzo commented 1 year ago

scriptjs is an old and no more maintained repository. I've replaced it with vanilla js code

omichelsen commented 1 year ago

Could this be implemented with import('https://...') instead?

luca-peruzzo commented 1 year ago

Could this be implemented with import('https://...') instead?

The js file has window references internally, importing like a cjs import probably would break projects which use server-side rendering.

piotr-cz commented 7 months ago

I think you should commit an updated package-lock.json file

luca-peruzzo commented 7 months ago

I think you should commit an updated package-lock.json file

done