capacitor-community / apple-sign-in

Sign in with Apple Support
MIT License
135 stars 58 forks source link

New requirements for gradle 8 #93

Closed luca-peruzzo closed 1 year ago

luca-peruzzo commented 1 year ago

Hi! πŸ‘‹

Firstly, thanks for your work on this project! πŸ™‚

Today I used patch-package to patch @capacitor-community/apple-sign-in@4.0.0 for the project I'm working on.

Please replace the package attribute in AndroidManifest.xml with the namespace attribute in build.gradle cause is required by gradle 8.

Here is the diff that solved my problem:

diff --git a/node_modules/@capacitor-community/apple-sign-in/android/build.gradle b/node_modules/@capacitor-community/apple-sign-in/android/build.gradle
index 237ba31..724fe7c 100644
--- a/node_modules/@capacitor-community/apple-sign-in/android/build.gradle
+++ b/node_modules/@capacitor-community/apple-sign-in/android/build.gradle
@@ -17,6 +17,7 @@ buildscript {
 apply plugin: 'com.android.library'

 android {
+    namespace "com.getcapacitor.community.applesignin.applesignin"
     compileSdkVersion project.hasProperty('compileSdkVersion') ? rootProject.ext.compileSdkVersion : 32
     defaultConfig {
         minSdkVersion project.hasProperty('minSdkVersion') ? rootProject.ext.minSdkVersion : 22
diff --git a/node_modules/@capacitor-community/apple-sign-in/android/src/main/AndroidManifest.xml b/node_modules/@capacitor-community/apple-sign-in/android/src/main/AndroidManifest.xml
index 22b7aa9..9957c84 100644
--- a/node_modules/@capacitor-community/apple-sign-in/android/src/main/AndroidManifest.xml
+++ b/node_modules/@capacitor-community/apple-sign-in/android/src/main/AndroidManifest.xml
@@ -1,5 +1,4 @@

-  <manifest xmlns:android="http://schemas.android.com/apk/res/android"
-      package="com.getcapacitor.community.applesignin.applesignin">
+  <manifest xmlns:android="http://schemas.android.com/apk/res/android">
   </manifest>

\ No newline at end of file

This issue body was partially generated by patch-package.

jcesarmobile commented 1 year ago

capacitor CLI 5.0.2 already patches this

also version 5.0.0 of the plugin has just been released with this change