search

capacitor-community / background-geolocation

A Capacitor plugin that sends you geolocation updates, even while the app is in the background.
MIT License
185 stars 57 forks source link

Add further customization options #8

Closed jjasloot closed 3 years ago

jjasloot commented 3 years ago

Hey there,

During the usage of this plugin at my job in ran into some things I wanted to be able to change. This included foremost having silent notifications, as I found it annoying to get a vibration when moving the app to the background. I also needed to be able to set a custom icon for the notification as the app logo doesn't seem to work on all devices. (e.g. on the Pixel 3c simulator in Android studio it showed as a white circle as opposed to the app logo). This should hopefully also solve #7.

On the documentation side I added the new options to the readme and also reshuffled it to make the universally usable settings appear first followed by the Android specific settings.

I hope you will be able to have a look at the changes. Please let me know if you want me to make any changes.

Thanks for your work on this plugin!

diachedelic commented 3 years ago

Thanks for your suggestions. I silenced the background notification by default, and added channel name and icon options via strings.xml. Does that work for you?

jjasloot commented 3 years ago

Hey @diachedelic, thanks for your changes, I think they do cover everything I wanted, and also in a neater way :)