search

capacitor-community / barcode-scanner

A fast and efficient (QR) barcode scanner for Capacitor
MIT License
437 stars 169 forks source link

Anyway to border around qrcode #176

Closed huuhait closed 1 year ago

thegnuu commented 1 year ago

With the current implementation this is not possible, I am working on a new version based on ml-kit that will allow this.

huuhait commented 1 year ago

With the current implementation this is not possible, I am working on a new version based on ml-kit that will allow this.

Hope it will done very soon

thegnuu commented 1 year ago

It should, I am doing my best to release it asap, unfortunately I am kinda busy with other projects at the moment...

5nyper commented 1 year ago

@thegnuu I presume it's still a WiP? is a branch available for it that I could potentially assist with?

JanMisker commented 1 year ago

@thegnuu I presume it's still a WiP? is a branch available for it that I could potentially assist with?

Yeah the ml-kit branch. There are some issues marked with [ML-Kit] that could be starting points to contribute.

This one is about this particular issue https://github.com/capacitor-community/barcode-scanner/issues/205

thegnuu commented 1 year ago

@5ynatra I just release v5.0.0-beta.1 based on the ml-kit branch. My current problem is to map the points returned by ml-kit to the matching pixel values in the webview. If we can achieve this, it should be quite easy to implement the outlines yourself... If you would have time to look at this and maybe come up with a working solution this would be awesome :)

thegnuu commented 1 year ago

See #217

thegnuu commented 1 year ago

This is as well related to this issue #205. I will close this one here to remove "duplicates"