capacitor-community / contacts

Contacts Plugin for Capacitor
https://capacitor-community.github.io/contacts/
125 stars 54 forks source link

feat: Capacitor 6 Support #118

Closed ckoon-infopro closed 3 months ago

ckoon-infopro commented 7 months ago

Capacitor 6.0 has been announced, bringing support for Android 14 and iOS 17. https://ionic.io/blog/announcing-capacitor-6-0

Updating Plugins to 6.0: https://capacitorjs.com/docs/updating/plugins/6-0

tafelnl commented 7 months ago

Thanks. I'm on the verge of upgrading this plugin to Capacitor v6. I'm waiting for just a short while to see if the Capacitor team will release some more info about converting to SPM (https://capacitorjs.com/docs/updating/plugins/6-0#add-spm-support)

ckoon-infopro commented 7 months ago

Thanks. I'm on the verge of upgrading this plugin to Capacitor v6. I'm waiting for just a short while to see if the Capacitor team will release some more info about converting to SPM (https://capacitorjs.com/docs/updating/plugins/6-0#add-spm-support)

According to the blog post, SPM support is experimental, and it is recommended to keep it out of production for now.

tafelnl commented 7 months ago

I know it says that. But a few things:

  1. Their own plugins are using SPM, which makes me believe it's actually production ready.
  2. Parts of their documentation is outdated; e.g. it still makes mentions of Capacitor v6 being in beta
  3. It says SPM support is coming soon. So I don't think it will take them too long to come up with clearer documentation

That being said. I just released v6.0.5-alpha.0. So you can try that out already

qliqdev commented 7 months ago

@tafelnl hello. Could you tell for what this plugin requires permission

<uses-permission android:name="android.permission.WRITE_CONTACTS" />

Can i remove this permission if I do not use write features?

image

this warning is really annoying

May be it will be good idea to modify this block?

@CapacitorPlugin(
    name = "Contacts",
    permissions = { @Permission(strings = { Manifest.permission.READ_CONTACTS, Manifest.permission.WRITE_CONTACTS }, alias = "contacts") }
)
tafelnl commented 7 months ago

@qliqdev

Understandable, please open a new issue with a feature request. Then we can see what we can do

cromdev commented 7 months ago

Bump on this one - any view on date?

tafelnl commented 6 months ago

You should ask the Capacitor team. In the meantime you can try and use v6.0.5-alpha.0

cromdev commented 6 months ago

Ah, there's alpha, great! I'll try it out, thanks.

josuelmm commented 6 months ago

I already tested it with Capacitor 6, doing a forced installation and it works perfectly.

Noy25 commented 4 months ago

Hey, any updates on when Capacitor 6 will be officially supported by this package? (i.e. post alpha version)

robingenz commented 4 months ago

Hi @tafelnl,

I'm on the verge of upgrading this plugin to Capacitor v6. I'm waiting for just a short while to see if the Capacitor team will release some more info about converting to SPM

As far as I know, no further information is coming for the time being. SPM support in Capacitor 6 is currently still experimental, even though it is already used in the official plugins.

It would be great if we could release Capacitor 6 support with the latest tag. If you like, I can create a PR for you.

josuelmm commented 3 months ago

Any news?

wwwguy commented 3 months ago

Any updates? (those using this in their apps are getting squeezed by the Google requirement to target Android 14 by the end of 8/2024 which ultimately requires a move to Capacitor 6).

tafelnl commented 3 months ago

Just published it to npm

robingenz commented 3 months ago

Thank you!

josuelmm commented 3 months ago

Muchas gracias

wwwguy commented 3 months ago

yesss... perfect! Many thanks!