search

capacitor-community / contacts

Contacts Plugin for Capacitor
https://capacitor-community.github.io/contacts/
119 stars 52 forks source link

šŸš€ Requesting permission to up the game #83

Closed tafelnl closed 1 year ago

tafelnl commented 1 year ago

@Idrimi @muuvmuuv @rdlabo @dotNetkow

First of all thank you for everything you guys have done to make this plugin available for the capacitor community. šŸ’Ŗ

I have noticed maintenance of this plugin has somewhat stalled. Maybe the interest of the maintainer has shifted, or maybe they simply lack the time. Which is totally fair of course. Any work done for the open source community is just an extra, especially when it's done without any compensation at all. šŸŽ–ļø

I was in need of a few (yet) unimplemented features. Recently I started adding those features to this plugin in a private fork. Eventually things escalated a bit, and I ended up refactoring a lot and finally I just wrote everything from scratch again. Haha.

I like to share my work with the capacitor community. It will close all but one open issues. I have written the plugin to support Capacitor v3, but I will also apply the necessary changes to support v4. That way both versions of Capacitor can be supported with the exact same plugin API.

I could just create a new repo and npm package. But I think it's more desirable to not create a bunch of different repositories every time a new maintainers stands up and refactors a bunch of stuff. So therefore I am requesting the permission of you guys to mostly take over the maintainership of this plugin and release a v3 (unfortunately a v2 has just been shipped, so these will be following each other shortly, but oh well) and a v4 versions of the plugin.

Sidenote: I already have the necessary permissions and roles for this repository and npm, so you do not need to do anything in case you guys agree @dotNetkow šŸ˜„

muuvmuuv commented 1 year ago

Go ahead :D thanks for the work. I am very excited about your changes

dotNetkow commented 1 year ago

Thanks for the great note about "upping the game." šŸ˜„

Idrimi hasn't worked on this since 2021, so I think that's fair. Of course, he can always come back/contribute at any time. And yes, much appreciated to keep updating this plugin rather than a new one. My only suggestion is to add a versions table in the readme like this example so as to be clear what is supported. Thank you!!!

Idrimi commented 1 year ago

@tafelnl perfectly fine for me. Will not have time to maintain it in the near future. So I'm happy if somebody takes care of the repo.

tafelnl commented 1 year ago

Alright, thanks for the responses guys. I will start moving my code to this repo probably starting this weekend. Need to do some last polishing first. šŸ˜„

tafelnl commented 1 year ago

I've just published two branches:

https://github.com/capacitor-community/contacts/tree/v3 https://github.com/capacitor-community/contacts/tree/v4

I'll probably merge v3 to main, and keep v4 rebased on v3. That way we can easily provide LTS for both versions.

@dotNetkow Could you give me permission to publish GitHub Pages for this repo? I've added extensive docs tailored for GitHub Pages :smile:

dotNetkow commented 1 year ago

OK @tafelnl I added you with a Maintain role. See if that works! I also turned on GH pages for main branch.