capacitor-community / date-picker

Native DateTime Picker Plugin for Capacitor Apps
MIT License
87 stars 29 forks source link

Capacitor 3 Support #30

Closed thomasvidas closed 1 year ago

thomasvidas commented 3 years ago

Capacitor 3 is currently in alpha (with a beta quickly approaching!). It would be great if this plugin released a Capacitor 3 compatible version around the same time as the full release.

Happy to help out if I can 😄

danielprrazevedo commented 3 years ago

Hello @thomasvidas! I just did a beta publication of the plugin, I would love it if you could test it and give me feedback

npm install @ capacitor-community/date-picker@beta beta doc

Please note that we have some changes to the plugin and the way it is called

rpascal commented 3 years ago

Any word if we can expect Capacitor 3 support in the near feature?

danielprrazevedo commented 3 years ago

Yes we can. I'll try to make another release this week, I confess that I'm a little out of time to finish everything, but there is already a beta version for capacitor 3, but some features on android are still incomplete

amanngoel commented 3 years ago

Hey @danielprrazevedo , when can we expect a stable release for Capacitor 3

amitkrgautm commented 3 years ago

@danielprrazevedo Any update about stable release.

sburnicki commented 3 years ago

Any update on this? 😊 This is the last plugin that keeps me from updating to capacitor3 in my project.

NLueg commented 3 years ago

I use the version in my productive app for like 3 weeks on iOS and Android and don't experience any issues. In my opinion, the beta release can be marked as stable.

aliantjamaica commented 3 years ago

@danielprrazevedo any update on the capacitor v3 datepicker fix??

aliantjamaica commented 3 years ago

Yes we can. I'll try to make another release this week, I confess that I'm a little out of time to finish everything, but there is already a beta version for capacitor 3, but some features on android are still incomplete

@danielprrazevedo any update?

jjacobs33589 commented 3 years ago

I've updated to capacitor 3 and this is the only plugin having problems because it doesn't support capacitor 3. Is there any update on when it will?

NLueg commented 3 years ago

@jjacobs33589 you can use the beta-version for your Cap 3 app. You can install it with:

npm install @capacitor-community/date-picker@beta

In my opinion, this release can be marked as stable as I use the code in production for like 2 months.

nirajhinge commented 3 years ago

Just noticed what looks like an error with the beta build if we try to install it on capacitor 3.2.3 with the following dependency issue:

➜ npm install @capacitor-community/date-picker@beta
npm ERR! code ERESOLVE
npm ERR! ERESOLVE unable to resolve dependency tree
npm ERR! 
npm ERR! While resolving: project@0.0.1
npm ERR! Found: @capacitor/core@3.2.3
npm ERR! node_modules/@capacitor/core
npm ERR!   @capacitor/core@"3.2.3" from the root project
npm ERR! 
npm ERR! Could not resolve dependency:
npm ERR! peer @capacitor/core@"3.0.0-beta.1" from @capacitor-community/date-picker@0.3.0
npm ERR! node_modules/@capacitor-community/date-picker
npm ERR!   @capacitor-community/date-picker@"0.3.0" from the root project
npm ERR! 
npm ERR! Fix the upstream dependency conflict, or retry
npm ERR! this command with --force, or --legacy-peer-deps
npm ERR! to accept an incorrect (and potentially broken) dependency resolution.

This seems to be an issue because the dependencies on the project is locked on this capacitor version 3.0.0-beta.1. Works if we use the --force flag for now.

joplaete commented 3 years ago

Hey, anyone tried if this works with Capacitor 3.2.5 and date-picker beta (0.3.0)?

    "@capacitor/core": "^3.2.5",
    "@capacitor/ios": "^3.2.5",
    "@capacitor-community/date-picker": "^0.3.0",

As per docs using import { DatePicker } from '@capacitor-community/date-picker'; gives me Module '"@capacitor-community/date-picker"' has no exported member 'DatePicker'.

Thanks

NLueg commented 3 years ago

Hey @joplaete yes for me it is working with your mentioned version. Also, my import is the same. Maybe try to delete the node_modules and the package-lock.json and install it again to verify that you are really using the beta-version?

joplaete commented 3 years ago

great that seems to have fixed it.. thanks @NLueg !

bram96 commented 2 years ago

Is there a plan for releasing a stable version for Capacitor 3?

elvisgraho commented 2 years ago

Ionic Framework v6 ditched their old ion-datetime and this plugin seems like an alternative to Ionic's "depracted" datepicker

pioneersingh321 commented 2 years ago

Error: Uncaught (in promise): Error: Method not implemented. Error: Method not implemented. at DatePickerWeb.present

Pynka commented 2 years ago

Maybe this helps you: https://github.com/capacitor-community/date-picker/issues/63#issuecomment-1217887124