capacitor-community / electron

Deploy your Capacitor apps to Linux, Mac, and Windows desktops, with the Electron platform! 🖥️
https://capacitor-community.github.io/electron/
MIT License
318 stars 58 forks source link

Lack of documentation for release 5.0.1 #267

Closed jepiqueau closed 9 months ago

jepiqueau commented 9 months ago

Describe the bug What are the main changes between v4 and V5, they must be explained

i am the developer of @capacitor-community/sqlite and it was working nicely in v4 and not in v5 in the angular-sqlite-app-starter

 angular-sqlite-app-starter@1.0.0 build
> tsc && electron-rebuild

node_modules/builder-util-runtime/out/httpExecutor.d.ts:9:5 - error TS2411: Property ''accept-charset'' of type 'string | string[]' is not assignable to 'string' index type 'string'.

9     [key: string]: string;
      ~~~~~~~~~~~~~~~~~~~~~~
...

Found 16 errors in the same file, starting at: node_modules/builder-util-runtime/out/httpExecutor.d.ts:9

To Reproduce Steps to reproduce the behavior:

  1. Go to '...'
  2. Click on '....'
  3. Scroll down to '....'
  4. See error

Expected behavior A clear and concise description of what you expected to happen.

Screenshots If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

Additional context Add any other context about the problem here.

mtpc commented 9 months ago

FYI, this is fixed by adding "skipLibCheck": true in the tsconfig.json that's inside the electron folder

jepiqueau commented 9 months ago

@mtpc thanks for the fix

gpetrov commented 6 months ago

this is also fixed by just updating the dev dependencies of electron-updater to v6 and electron-builder to v24 @IT-MikeS can you update those on the default template?