search

capacitor-community / electron

Deploy your Capacitor apps to Linux, Mac, and Windows desktops, with the Electron platform! 🖥️
https://capacitor-community.github.io/electron/
MIT License
318 stars 58 forks source link

Splash screen in v5 seems to be broken #280

Open WolfWalter opened 4 months ago

WolfWalter commented 4 months ago

Describe the bug After updating to 5.0.1 the splash screen is nearly blank. But after taking a closer look the splash.png is in the upper left corner, but super tiny.

To Reproduce Steps to reproduce the behavior:

  1. update to v5
  2. config a splash screen
  3. yarn cap open @capacitor-community/electron

Expected behavior Show the spash.png filling the view.

Screenshots If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

Additional context

I guess this change is leading to this behaviour: https://github.com/capacitor-community/electron/blame/f7ce86454469e967b41c1db8f51ddb942d278ca9/src/electron-platform/ElectronSplashScreen.ts#L48

I also played around with the before and after html snippets an ran in the same issue.

Frooger commented 4 months ago

Its already fixed and in the main branch: Fix: Put the image size into the splashscreen #272

but we need a new release for that at npm :)

WolfWalter commented 4 months ago

Ok. But that is just a PR, so it is not on the main branch. There is even another PR for this issue https://github.com/capacitor-community/electron/pull/201

tradingproject19 commented 2 months ago

@Frooger any plan on merging this PR?