Closed luca-peruzzo closed 12 months ago
Hi! 👋
Firstly, thanks for your work on this project! 🙂
Today I used patch-package to patch @capacitor-community/facebook-login@4.0.0 for the project I'm working on.
@capacitor-community/facebook-login@4.0.0
Please replace the package attribute in AndroidManifest.xml with the namespace attribute in build.gradle cause is required by gradle 8.
Here is the diff that solved my problem:
diff --git a/node_modules/@capacitor-community/facebook-login/android/build.gradle b/node_modules/@capacitor-community/facebook-login/android/build.gradle index 2bc9ece..781697f 100644 --- a/node_modules/@capacitor-community/facebook-login/android/build.gradle +++ b/node_modules/@capacitor-community/facebook-login/android/build.gradle @@ -17,6 +17,7 @@ buildscript { apply plugin: 'com.android.library' android { + namespace "com.getcapacitor.community.facebooklogin" compileSdkVersion project.hasProperty('compileSdkVersion') ? rootProject.ext.compileSdkVersion : 32 defaultConfig { minSdkVersion project.hasProperty('minSdkVersion') ? rootProject.ext.minSdkVersion : 22 diff --git a/node_modules/@capacitor-community/facebook-login/android/src/main/AndroidManifest.xml b/node_modules/@capacitor-community/facebook-login/android/src/main/AndroidManifest.xml index 27dbda9..c775119 100644 --- a/node_modules/@capacitor-community/facebook-login/android/src/main/AndroidManifest.xml +++ b/node_modules/@capacitor-community/facebook-login/android/src/main/AndroidManifest.xml @@ -1,4 +1,3 @@ - <manifest xmlns:android="http://schemas.android.com/apk/res/android" - package="com.getcapacitor.community.facebooklogin"> + <manifest xmlns:android="http://schemas.android.com/apk/res/android"> </manifest>
This issue body was partially generated by patch-package.
this is fixed in 5.0.0
Hi! 👋
Firstly, thanks for your work on this project! 🙂
Today I used patch-package to patch
@capacitor-community/facebook-login@4.0.0
for the project I'm working on.Please replace the package attribute in AndroidManifest.xml with the namespace attribute in build.gradle cause is required by gradle 8.
Here is the diff that solved my problem:
This issue body was partially generated by patch-package.