capacitor-community / facebook-login

Facebook Login support
MIT License
98 stars 52 forks source link

registerPlugin(com.getcapacitor.community.facebooklogin.FacebookLogin.class) not necessary #137

Closed co-dax closed 10 months ago

co-dax commented 11 months ago

The plugin works without

registerPlugin(
      com.getcapacitor.community.facebooklogin.FacebookLogin.class
    );

from the following piece of code

import android.os.Bundle; // required for onCreate parameter

public class MainActivity extends BridgeActivity {

  @Override
  public void onCreate(Bundle savedInstanceState) {
    super.onCreate(savedInstanceState);
    registerPlugin(
      com.getcapacitor.community.facebooklogin.FacebookLogin.class
    );
  }
}

...which is reported as required for the plugin to work at the following link https://github.com/capacitor-community/facebook-login#android-configuration

Am I missing something?

Thanks.

juanmaldonadodev commented 10 months ago

I have the same question. Anyone knows if is it required or not?

rdlabo commented 10 months ago

Thanks report. This is unnecessary from v4. I removed from readme: https://github.com/capacitor-community/facebook-login/commit/817a16f66c63c48bed7a4f8d6cd06a67e31e693d

co-dax commented 10 months ago

Thanks @rdlabo!