capacitor-community / facebook-login

Facebook Login support
MIT License
98 stars 52 forks source link

Installing latest version does not get correct podspec version 17 #148

Closed viking2917 closed 2 months ago

viking2917 commented 3 months ago

Describe the bug

The latest podspec file does not get installed for iOS correctly for me.

To Reproduce Steps to reproduce the behavior:

  1. npm i --save @capacitor-community/facebook-login
  2. Look at node_modules/@capacitor-community/facebook-login/ it shows
s.dependency 'FBSDKCoreKit', '16.1.3'
s.dependency 'FBSDKLoginKit', '16.1.3'

even though the current file in the repo is using version 17.0.

I am using Ionic 7, Angular 17, node v 18.

Clean Build Folder, uninstall and reinstall, nothing seems to change the outcome.

What might I be doing wrong, or does this need to be packaged somehow before it can be used?

Thank you for any assistance.

Expected behavior

Installed file should match the repo.

viking2917 commented 2 months ago

The new 6.0 release (https://github.com/capacitor-community/facebook-login/issues/149) seems to have fixed this. Closing this.