search

capacitor-community / facebook-login

Facebook Login support
MIT License
103 stars 54 forks source link

Migration to v3 doc. #47

Closed vovikdrg closed 2 years ago

vovikdrg commented 3 years ago

Describe the bug AppDelegate.swift:3:8: error: no such module 'FacebookCore'

To Reproduce I did migrated from old version to 3 and was not able to compile my app

Expected behavior Maybe it make sense to add into docs information that during upgrade to make sure that we import import FBSDKCoreKit Instead of import FacebookCore

rdlabo commented 3 years ago

@vovikdrg Can you create pull request?? I don't currently have it available because we can see the errors, but I'll be happy to review it if you create one.

vovikdrg commented 3 years ago

@rdlabo I was thinking to add new section in readme with just one note. Are you fine with that?

rdlabo commented 3 years ago

@vovikdrg I'm sorry I overlooked this reply. I created file https://github.com/capacitor-community/facebook-login/blob/master/BREAKING.md , so please add v3 braking change section. Thanks.

vovikdrg commented 3 years ago

@rdlabo thanks will do :)

rdlabo commented 2 years ago

This may not has any update, so will close. If be update, please re-open. Thanks.