capacitor-community / facebook-login

Facebook Login support
MIT License
103 stars 52 forks source link

Android configuration #67

Closed sbellver closed 2 years ago

sbellver commented 2 years ago

Describe the bug When I change MainActivity class gives an error

To Reproduce Change MainActivity.java and add/override:

public class MainActivity extends BridgeActivity {
    @Override
    public void onCreate(Bundle savedInstanceState) {
        super.onCreate(savedInstanceState);
        registerPlugin(com.getcapacitor.community.facebooklogin.FacebookLogin.class);
    }
}

Then, when I do nix cap open android:

error: cannot find symbol
    public void onCreate(Bundle savedInstanceState) {
                         ^
  symbol:   class Bundle
sbellver commented 2 years ago

Maybe the README needs an update:

import android.os.Bundle;
import com.getcapacitor.BridgeActivity;
import com.getcapacitor.community.facebooklogin.FacebookLogin;

public class MainActivity extends BridgeActivity {
  @Override
    public void onCreate(Bundle savedInstanceState) {
        super.onCreate(savedInstanceState);
        registerPlugin(com.getcapacitor.community.facebooklogin.FacebookLogin.class);
    }
}

First, we need to import add import android.os.Bundle; not sure if import com.getcapacitor.community.facebooklogin.FacebookLogin; is mandatory

stewones commented 2 years ago

Capacitor 3 should handle those imports automatically

markterrill commented 2 years ago

Same problem. Same fix, ie add import android.os.bundle. npx cap sync didn't magically fix it either. Looks to be a straight up vanilla header requirement for that file.

Caperious commented 2 years ago

Is this step needed? Like @stewones said, Capacitor 3 should handle this imports automatically https://capacitorjs.com/docs/updating/3-0#switch-to-automatic-android-plugin-loading