search

capacitor-community / facebook-login

Facebook Login support
MIT License
103 stars 52 forks source link

Added initialization method for Capacitor Web #78

Closed prashantchoudhary closed 2 years ago

prashantchoudhary commented 2 years ago

As there was no initialization method for web, it was making the documentation confusing. Additional, suggested method needed to directly call FB script inside index.html, which in my opinion could be omitted by having the implementation in the Plugin itself. This makes both integration and documentation simpler for the users. A similar approach has been taken by CapacitorGoogleAuth plugin by CodetrixStudio.

Please review the PR and suggest/improve if anything is needed.

rdlabo commented 2 years ago

Awesome work! I Thank you for your wonderful idea.

prashantchoudhary commented 2 years ago

Wow, that was the quickest merge I have seen in an open source community. Thank you for the awesome library.

rdlabo commented 2 years ago

v3.3.0 is released!! Thanks your contribution!!

https://github.com/capacitor-community/facebook-login/releases/tag/v3.3.0