capacitor-community / facebook-login

Facebook Login support
MIT License
103 stars 54 forks source link

Does this library makes use of code_verifier and code_challenger? #8

Closed bartboersma closed 4 years ago

bartboersma commented 4 years ago

Hi people who made this library,

First of all, awesome library!

I have successfully implemented Facebook login on Android and iOS using your library. While I was debugging your library, I couldn't find if a code_verifier and code_challenger is used in order to prevent malicious app's using your code (PKCE). I have implemented Google Login myself by following this guide where they explain using the code_verifier and code_challenger. So I was wondering does this library use PKCE by using a code_verifier and code_challenger?

Regards,

Bart

rdlabo commented 4 years ago

Hi. This plugin use Facebook Login Manager Plugin, and code_verifier and code_challenger may be in this. (I can't find how to use in outside of Login Manager)

https://github.com/facebook/facebook-ios-sdk https://github.com/facebook/facebook-android-sdk

Thanks.

bartboersma commented 4 years ago

Thank you for your response