Avoid Crashes If Play Services Unavailable

ramikhafagi96 commented 1 year ago

Description

We have been suffering a lot of crashes on Huawei devices and some other devices like Redmi and Oppo in FCMPlugin.java, it happened on the line data.put("token", tokenResult.getResult());.

Exception com.google.android.gms.tasks.RuntimeExecutionException: java.io.IOException: java.util.concurrent.ExecutionException: java.io.IOException: SERVICE_NOT_AVAILABLE
at com.google.android.gms.tasks.zzw.getResult (com.google.android.gms:play-services-tasks@@18.0.1:3)
at com.getcapacitor.community.fcm.FCMPlugin.lambda$getToken$6 (FCMPlugin.java:68)
at com.getcapacitor.community.fcm.FCMPlugin$$ExternalSyntheticLambda0.onComplete
at com.google.android.gms.tasks.zzi.run (com.google.android.gms:play-services-tasks@@18.0.1:1)
at android.os.Handler.handleCallback (Handler.java:938)
at android.os.Handler.dispatchMessage (Handler.java:99)
at android.os.Looper.loop (Looper.java:264)
at android.app.ActivityThread.main (ActivityThread.java:8245)
at java.lang.reflect.Method.invoke
at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run (RuntimeInit.java:632)
at com.android.internal.os.ZygoteInit.main (ZygoteInit.java:1049)

The reason for this error is that on some devices google-play-services is not installed or not working for some reason, and the code tries to access tokenResult.getResult() and it results in an exception which is not handled and the app crashes.
addOnFailureListener listener wasn't invoked and the exception doesn't get handled
By reviewing the docs found that the failure in this case is handled in a different way which is the one used in this PR
After this fix the app doesn't crash and the exception is handled

How To Reproduce

Go to settings and disable google play services
Run the app and call getToken()

Suggestion

It would be good also if we check for google-play-services availability as mentioned here, that will help the user to avoid using the app without FCM and not getting any notifications

Update

I created a capacitor plugin which allows to check if google play services is available and request enabling google play services on the device, for anyone who needs this functionality this is link for the plugin: https://www.npmjs.com/package/@cartona/capacitor-google-play-availability

ramikhafagi96 commented 1 year ago

@stewones a ping just in case you haven't seen it :), thanks for your time in advance.

stewones commented 1 year ago

going to publish later today

capacitor-community / fcm