search

capacitor-community / fcm

Enable Firebase Cloud Messaging for Capacitor apps
https://capacitor.ionicframework.com/docs/
MIT License
237 stars 83 forks source link

Execute deleteInstanceId on a background thread #29

Closed trytuna closed 4 years ago

trytuna commented 4 years ago

Calling deleteInstanceId() on a background thread is mandatory since this call is blocking.

See https://firebase.google.com/docs/reference/android/com/google/firebase/iid/FirebaseInstanceId#deleteInstanceId()

This cause my App to suspend other network requests that could have called in parallel. The code I submitted solved the issue.

Thanks a lot for the plugin!

stewones commented 4 years ago

Thanks @trytuna looks very nice I’ll be testing and releasing soon

trytuna commented 4 years ago

Any updates on this? Sorry for being impatient but this effects our App quite excessive

zUniQueX commented 4 years ago

Any updates? I am having the same problem

stewones commented 4 years ago

it's patched to 1.0.1 thanks @trytuna