capacitor-community / fcm

Enable Firebase Cloud Messaging for Capacitor apps
https://capacitor.ionicframework.com/docs/
MIT License
243 stars 83 forks source link

Capacitor 3 Support #59

Closed thomasvidas closed 3 years ago

thomasvidas commented 3 years ago

Capacitor 3 is currently in alpha. It would be great if this plugin released a Capacitor 3 compatible version around the same time as the full release.

The official Capacitor Push Notifications Plugin was just updated to be v3 compatible. Once a new version is pushed to npm, we'd be able to start the work on migrating over.

Happy to help out if I can šŸ˜„

stewones commented 3 years ago

I will as soon as full release is out

charlouze commented 3 years ago

For those who are currently building an app and want to use capacitor v3, I've been able to use this plugin :

import { FCMProtocol } from '@capacitor-community/fcm';
import { registerPlugin } from '@capacitor/core';

const Fcm = registerPlugin<FCMProtocol>(
  'FCMPlugin',
  {},
);
EinfachHans commented 3 years ago

@stewones Maybe you can already do this in a separate Branch, so we can use tis Branch until V3 is out of RC state?

stanstanov commented 3 years ago

I waiting this plugin for capacitor V3 too

savgiannis commented 3 years ago

Hi,

Capacitor 3 just was released. Maybe it's time!

aechan commented 3 years ago

Can someone please update this for v3? This is the last plugin we're using that hasn't been updated yet.

kyleabens commented 3 years ago

For those who are currently building an app and want to use capacitor v3, I've been able to use this plugin :

import { FCMProtocol } from '@capacitor-community/fcm';
import { registerPlugin } from '@capacitor/core';

const Fcm = registerPlugin<FCMProtocol>(
  'FCMPlugin',
  {},
);

Unfortunately this did not work for me. Still getting "Compiling for iOS 11.0, but module 'Capacitor' has a minimum deployment target of iOS 12.0" when I try to build in xcode. Am I missing something?

aechan commented 3 years ago

@kyleabens that issue is solved by setting the deployment target for the capacitor fcm project to 12.0 in Xcode. Usually a warning will pop up in the issues menu after a failed build that says something like ā€œUpdate project to recommended settingsā€ and accepting all the recommended settings will allow you to build.

It would just be really nice if we could get this repo updated to v3 so we didnā€™t have to go through this process on every build because a capacitor sync will discard these changes and youā€™ll have to update the settings all over again.

Nazirovich commented 3 years ago

Hello!!

any update about upgrading it to Capacitor 3 ?!

stewones commented 3 years ago

I'm too busy right now, always open for reviewing and testing PRs though.

hemangsk commented 3 years ago

@stewones , I've opened a PR at https://github.com/capacitor-community/fcm/pull/76 for v3 support. Could you please take a look?

stewones commented 3 years ago

released on v2 which also supports Firebase 8

somq commented 2 years ago

For those who are currently building an app and want to use capacitor v3, I've been able to use this plugin :

import { FCMProtocol } from '@capacitor-community/fcm';
import { registerPlugin } from '@capacitor/core';

const Fcm = registerPlugin<FCMProtocol>(
  'FCMPlugin',
  {},
);

Unfortunately this did not work for me. Still getting "Compiling for iOS 11.0, but module 'Capacitor' has a minimum deployment target of iOS 12.0" when I try to build in xcode. Am I missing something?

Type has changed in latest version(s) for info. (v2.0.2)

import { FCMPlugin } from '@capacitor-community/fcm'
import { registerPlugin } from '@capacitor/core';

const fcm = registerPlugin<FCMPlugin>(
  'FCMPlugin',
  {},
);