Closed tafelnl closed 1 year ago
Thanks for this fix.
Pardon the ignorance, but how do I incorporate into an existing project using Capacitor 2?
My build.gradle:
`buildscript {
repositories {
google()
jcenter()
}
dependencies {
classpath 'com.android.tools.build:gradle:4.2.1'
classpath 'com.google.gms:google-services:4.3.10'
// NOTE: Do not place your application dependencies here; they belong
// in the individual module build.gradle files
}
}
apply from: "variables.gradle"
allprojects { repositories { google() jcenter() } }
task clean(type: Delete) { delete rootProject.buildDir }`
I am not sure what you're saying. But until it's merged and published to npm, you can install my hotfix branch directly from github.
(for example like this: npm i git+https://github.com/tafelnl/capacitor-oauth2.git#fix-build-gradle
)
Sorry, late night, realized this later and should have deleted the comment.
Wish I would have known you had already published a build.
Went ahead and upgraded to Capacitor 3 and got everything working.
Appreciate it.
Backported the fix for https://github.com/moberwasserlechner/capacitor-oauth2/issues/136 to the version of this plugin that supports Capacitor v2.
I think it would be best to create a
v2
branch in this project, then point this PR to that branch, and finally release av2.1.1
to npm (and GitHub)