capacitor-community / generic-oauth2

Generic Capacitor OAuth 2 client plugin. Stop the war in Ukraine!
MIT License
231 stars 113 forks source link

fix `build.gradle` file #188

Closed tafelnl closed 1 year ago

tafelnl commented 2 years ago

Backported the fix for https://github.com/moberwasserlechner/capacitor-oauth2/issues/136 to the version of this plugin that supports Capacitor v2.

I think it would be best to create a v2 branch in this project, then point this PR to that branch, and finally release a v2.1.1 to npm (and GitHub)

bobbydowling commented 2 years ago

Thanks for this fix.

Pardon the ignorance, but how do I incorporate into an existing project using Capacitor 2?

My build.gradle:

`buildscript {

repositories {
    google()
    jcenter()
}
dependencies {
    classpath 'com.android.tools.build:gradle:4.2.1'
    classpath 'com.google.gms:google-services:4.3.10'

    // NOTE: Do not place your application dependencies here; they belong
    // in the individual module build.gradle files
}

}

apply from: "variables.gradle"

allprojects { repositories { google() jcenter() } }

task clean(type: Delete) { delete rootProject.buildDir }`

tafelnl commented 2 years ago

I am not sure what you're saying. But until it's merged and published to npm, you can install my hotfix branch directly from github.

(for example like this: npm i git+https://github.com/tafelnl/capacitor-oauth2.git#fix-build-gradle)

bobbydowling commented 2 years ago

Sorry, late night, realized this later and should have deleted the comment.

Wish I would have known you had already published a build.

Went ahead and upgraded to Capacitor 3 and got everything working.

Appreciate it.