search

capacitor-community / generic-oauth2

Generic Capacitor OAuth 2 client plugin. Stop the war in Ukraine!
MIT License
223 stars 106 forks source link

Support for Capacitor 5 #234

Closed WillooWisp closed 10 months ago

WillooWisp commented 1 year ago

Not possible to use plugin together with Capacitor 5 and Gradle 8+ due to the fact that all modules in project (either my own or added by Capacitor or community plugins) needs to declare the namespace outside the AndroidManifest.xml. Otherwise AGP v8 doesn't work, as explained here, https://github.com/ionic-team/capacitor/issues/6504.

razvantim commented 1 year ago

Having the same problem, an updated version would be great. Thank you

HatalDev commented 1 year ago

Working fine on iOS. On Android adding namespace 'com.byteowls.capacitor.oauth2' to the build.gradle of the package seems to fix the issue.

WillooWisp commented 1 year ago

@HatalDev is there a new release coming with this added then?

moberwasserlechner commented 1 year ago

I can work on the upgrade and release in june.

just keep in mind that this plugin is not related to ionic so i can not keep up with there release cycle. I'll have to do it in my spare time as most oss devs

hitmacreed commented 1 year ago

We can solve this issue(for now at least) with thenamespace with patch-package adding the namespace 'com.byteowls.capacitor.oauth2' on the node_modules and then patch it without the need of a fork for now Later on new install and will be automatically pathed for you and coworkers

NagariaHussain commented 1 year ago

namespace 'com.byteowls.capacitor.oauth2'

Hey! Where exactly do we add this line?

hitmacreed commented 1 year ago

Here

namespace 'com.byteowls.capacitor.oauth2'

Hey! Where exactly do we add this line?

meriturva commented 10 months ago

Hi to all, Is there any chance to have an updated version for capacitor 5.x? Thanks so mutch.

dennisameling commented 10 months ago

Can y'all please test this MR? It's working fine for me on Android, haven't tested yet on iOS. Thanks!

moberwasserlechner commented 10 months ago

Released 5.0.0 with Capacitor 5 Support Today.