search

capacitor-community / generic-oauth2

Generic Capacitor OAuth 2 client plugin. Stop the war in Ukraine!
MIT License
234 stars 115 forks source link

Hide navigation bar and footer on iOS #244

Open cordeveloper opened 11 months ago

cordeveloper commented 11 months ago

I am using the plugin to log in against azure b2c, I need that in IOS, in the window that opens from the internal browser, neither the upper nor the lower navigation bar is shown. This is the condition that Apple asks me to publish. Is there an option in the plugin that allows me to do this?

Description Capacitor version: Installed Dependencies:

@capacitor/cli: 4.8.0 @capacitor/android: 4.6.3 @capacitor/ios: 4.8.0 @capacitor/core: 4.7.0

Library version: -4.02

OAuth Provider: Azure AD (B2C) Your Plugin Configuration { appId: "", authorizationBaseUrl: , scope: "", accessTokenEndpoint: , responseType: "code", pkceEnabled: true, logsEnabled: true, web: { redirectUrl: ${REDIRECT_BASE}, windowOptions: "height=600,left=0,top=0", windowTarget: "_self", }, android: { redirectUrl: "", / accessTokenEndpoint: '', handleResultOnNewIntent: true, handleResultOnActivityResult: true, responseType: 'code' / handleResultOnNewIntent: true, handleResultOnActivityResult: true, }, ios: { redirectUrl: "", }, }

Affected Platform(s): *IOS

moberwasserlechner commented 11 months ago

Is this issue the same as #243 or does Apple require you to change sth else for #243?

cordeveloper commented 11 months ago

It is what would resolve both incidents, in fact I am going to close #243

On 4 Dec 2023, at 11:03, Michael Oberwasserlechner @.***> wrote:

Is this issue the same as #243 or does Apple require you to change sth else for #243? — Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you authored the thread.Message ID: @.***>

moberwasserlechner commented 11 months ago

@cordeveloper I guess you wanted to release the first version of the app because I updated mine a week ago and had no issues getting it approved to the app store.

cordeveloper commented 11 months ago

@moberwasserlechner I have been denied three times, for different reasons, from a bad user experience to saying that the SafariViewController api is not used... I login against Azure B2C and I think that if I manage to launch a browser without a user interface, surely They will validate me...

cordeveloper commented 11 months ago

@moberwasserlechner and this PR couldn't be the solution?: https://github.com/moberwasserlechner/capacitor-oauth2/pull/226/files/425ebe4e550c4be65a4f76af0acbeffe64c6a858#diff-8c1c5b6ec7c66a10ecf45d6e8cd2e4b86a59ae96d1b274f7aef2249b7a7738d6