search

capacitor-community / generic-oauth2

Generic Capacitor OAuth 2 client plugin. Stop the war in Ukraine!
MIT License
223 stars 106 forks source link

feat!: upgrade to Capacitor v6 #253

Closed tafelnl closed 2 months ago

tafelnl commented 2 months ago

I had to upgrade the lockfileVersion to version 3. Then I ran npx @capacitor/plugin-migration-v5-to-v6@latest. However I kept indentation with 4 spaces as that's what you've been using

tafelnl commented 2 months ago

@moberwasserlechner If your interest has shifted from this project, I can incorporate this project into the capacitor community plugins to ease the load, if you allow me

moberwasserlechner commented 2 months ago

@tafelnl Yes it might be for the best. Lately I have too much to do to keep this plugin up to date.

The Cap Plugin Community would be perfect place but I hope you have more luck on proposing this plugin as I did a few years ago

tafelnl commented 2 months ago

No worries. Thanks a lot for your efforts all this time. I've got write permissions for the community organization. So if you could transfer the repository to me, I can then transfer it to the community organization :)

moberwasserlechner commented 2 months ago

Currently I can not transfer it because of your fork exists.

image

I guess I have to merge this PR, then you can delete the fork and then the transfer should work?

tafelnl commented 2 months ago

Sorry about that. I just deleted it. Should work now

moberwasserlechner commented 2 months ago

Transfer Requested :)

tafelnl commented 2 months ago

Perfect, it's done. Thanks a lot! I'll be changing the scope to capacitor community, merge this PR and make a release soon 👍

tafelnl commented 2 months ago

I've renamed the package to @capacitor-community/generic-oauth2 (not merged yet, but changes available in this branch).

I also re-ran npm init @capacitor/plugin@latest so that the project is consistent with the other community plugins.

What do you think about generic-oauth2? I prefer it over something like oauth2 for example, because

  1. I don't want to be that guy that 'steals' this unique name
  2. and other oauth2-related plugins could pop up in the future, and then it might be confusing which is plugin is meant for what.
moberwasserlechner commented 2 months ago

@tafelnl Good choice.

moberwasserlechner commented 2 months ago

@tafelnl How did you create the release notes for v6.0.0? It looks very nice and clean.

tafelnl commented 2 months ago

Thanks. It's pretty simple actually. It's a native GitHub feature when creating a Release in GitHub. It looks like this:

More info: https://docs.github.com/en/repositories/releasing-projects-on-github/automatically-generated-release-notes

The breaking changes I did write myself though. That's not supported out of the box haha

moberwasserlechner commented 2 months ago

Oh cool. Need to keep this in mind.

OT: I have 2 other capacitor plugin that might be good candidates for the community org.

If you're willing to move those too I would prepare them like you did for this plugin and then transfer ownership to you.