capacitor-community / http

Community plugin for native HTTP
MIT License
208 stars 135 forks source link

Capacitor v4 support? #276

Closed ptmkenny closed 1 year ago

ptmkenny commented 2 years ago

Is your feature request related to a problem? Please describe.

Capacitor v4 has been released and it would be great for this plugin to support v4.

There is already a pull request for adding v4 support.

I know this plugin is in maintenance mode as stated in the README on the project page, and that a new official HTTP plugin will be added by the Ionic team.

So, I would appreciate a statement by the maintainers as to whether this plugin will be updated to v4, or the recommendation is to just wait for official HTTP support to be added in Capacitor 4.x.

dallastjames commented 2 years ago

Hello!

We have no plans to update this plugin to support Capacitor v4, rather our efforts have been focused on building out the new official HTTP plugin. While I don't have any official timeline I can share, it is well underway!

amuttsch commented 2 years ago

We use this plugin using capacitor v4 successfully. We had to patch the min iOS version however. Otherwise it works great!

Heres the patchfile:

diff --git a/CapacitorCommunityHttp.podspec b/CapacitorCommunityHttp.podspec
index c6d63200fd261e4b6fac8ef4a920013ae89a3590..55a39a0a95a860c50ff3ea652038699311bedaf1 100644
--- a/CapacitorCommunityHttp.podspec
+++ b/CapacitorCommunityHttp.podspec
@@ -11,7 +11,7 @@ Pod::Spec.new do |s|
   s.author = package['author']
   s.source = { git: package['repository']['url'], tag: s.version.to_s }
   s.source_files = 'ios/Plugin/**/*.{swift,h,m,c,cc,mm,cpp}'
-  s.ios.deployment_target = '12.0'
+  s.ios.deployment_target = '13.0'
   s.dependency 'Capacitor'
   s.swift_version = '5.1'
 end
diff --git a/ios/Podfile b/ios/Podfile
index c0c11bda69005b23ad445551a1580d875e357ffd..95bd006cb57d21e930cf1d9d8adeb016c9131658 100644
--- a/ios/Podfile
+++ b/ios/Podfile
@@ -1,4 +1,4 @@
-platform :ios, '12.0'
+platform :ios, '13.0'

 def capacitor_pods
   # Comment the next line if you're not using Swift and don't want to use dynamic frameworks
thomasvidas commented 2 years ago

I'm not sure if the official Http plugin will work with 4.0, or if will just be built into the Capacitor runtime itself. There were a few ideas bounced back and forth when I was still on the team. I could release another version based on #275 if the official plugin won't support 4.0, but rather 4.1+. Any insights on this @dallastjames?

ptmkenny commented 1 year ago

The official HTTP plugin was added in Capacitor 4.3, and there is a now outdated release for this plugin, so I'm closing this issue.