capacitor-community / in-app-review

Let users rate your app using native review app dialog for both Android and iOS.
MIT License
163 stars 20 forks source link

Is Android Readme up to date? #21

Closed Sysix closed 3 years ago

Sysix commented 3 years ago

Hello,

im confused about the implementation of this plugin. It says, we should add a code block in MainActivity.java file, like we did in capacitor 2.

Since Capacitor 3 the Plugins are Auto-Loaded: https://capacitorjs.com/docs/updating/3-0#switch-to-automatic-android-plugin-loading

The Plugin is also listed in capacitor.plugins.json, so I think that the README.md is outdated

skidrow88 commented 3 years ago

I think the Android doc is outdated for Capacitor 3. The Android app crashs if you implement the MainActivity.java file like Capacitor 2.

BigBerny commented 3 years ago

Did someone find out how to use it on Android? We're also struggling to get it to work.

dsuttonpreece commented 3 years ago

I'm also unable to get it working in Android. The plugin auto-loads fine, however, calling RateApp.requestReview() results in the following error:

Screen Shot 2021-09-17 at 4 42 40 pm
Nodonisko commented 3 years ago

Editing MainActivity.java is removed from new version 2.0.0.

Please test if it works for you.