search

capacitor-community / in-app-review

Let users rate your app using native review app dialog for both Android and iOS.
MIT License
163 stars 20 forks source link

fix: peer capacitor #31

Closed riderx closed 2 years ago

riderx commented 2 years ago

allow capacitor v4 apps

Nodonisko commented 2 years ago

Closing in favor of latest version

riderx commented 2 years ago

@Nodonisko thanks, but now your plugin is not compatible with all v3 app. My option was to allow both until everyone has migrated

Nodonisko commented 2 years ago

@Nodonisko That's the reason why we have versioning, simply use yarn install capacitor-rate-app@2.0.0 which is Capacitor 3 compatible.

riderx commented 2 years ago

Agree, in that way but will need to back port your fix in v2. Instead of keeping compat with both since there are no change concern the plugin in v4.

Nodonisko commented 2 years ago

@riderx I probably don't understand what changes should be done?

v2.0.0 - Support Capacitor 3 v3.0.0 - Support Capacitor 4

You can choose version depends of Capacitor version you use so everything is covered. Or am I missing something?

riderx commented 2 years ago

I see what I mean is not clear, let try this way:

In your v3.0.0 you added a License, this License is not present and available for people still in capacitor V3, if they want it, they have to upgrade like any new change you made in v4.0.0, witch can take some time for some company.

So if you want to still help them in v3.0.0 you need to back port your changes in it. Which could be avoided by my PR, since your plugin don't need to be forced in capacitor V4 at all.

That just a choice, one way make the life of everyone easier, the other one less, with no visible benefit.

Nodonisko commented 2 years ago

I think it won't work anyway because I can add Capacitor 3 to peers but I it is using Java 8 and new version of this plugin need Java 11, same as Capacitor 4.

riderx commented 2 years ago

i did this to all the plugins i maintain in @cap-go and no issue so far. As you want i'm not attached to this, i thought it was cool to share :)