search

capacitor-community / in-app-review

Let users rate your app using native review app dialog for both Android and iOS.
MIT License
163 stars 20 forks source link

Capacitor 5 support #41

Closed AE1NS closed 1 year ago

AE1NS commented 1 year ago

https://capacitorjs.com/docs/next/updating/plugins/5-0

vadimwe commented 1 year ago

+1

Nodonisko commented 1 year ago

Can you guys please try version 4.0.0-beta.1 especially on Android because I can't install Java 17 on my computer right now.

AE1NS commented 1 year ago

Thanks! What do you think about raising the version to 5.0.0 so it would be semantically connected to the capacitor version?

Nodonisko commented 1 year ago

I will bump it once I will have some feedback it actually works for Android. Did you tried it?

AE1NS commented 1 year ago

I can just run it in a debug context where my app has another bundle id. No modal opens, but that should be correct because this is not inside the store. Cant do any further tests right now.

grafik

2023-05-05 16:19:04.609  5845-5845  Capacitor/Plugin        ...              V  To native (Capacitor plugin): callbackId: 85375233, pluginId: RateApp, methodName: requestReview
2023-05-05 16:19:04.610  5845-5845  Capacitor               ...              V  callback: 85375233, pluginId: RateApp, methodName: requestReview, methodData: {}
2023-05-05 16:19:04.612  5845-6116  PlayCore                ...              I  UID: [10824]  PID: [5845] ReviewService : requestInAppReview (...)
2023-05-05 16:19:04.613  5845-6700  PlayCore                ...              I  UID: [10824]  PID: [5845] ReviewService : Initiate binding to the service.
2023-05-05 16:19:04.625  5845-5845  PlayCore                ...              I  UID: [10824]  PID: [5845] ReviewService : ServiceConnectionImpl.onServiceConnected(ComponentInfo{com.android.vending/com.google.android.finsky.inappreviewservice.InAppReviewService})
2023-05-05 16:19:04.626  5845-6700  PlayCore                ...              I  UID: [10824]  PID: [5845] ReviewService : linkToDeath
2023-05-05 16:19:04.735  2998-3081  Volley                  com.android.vending                  E  [6973] hzr.a: Unexpected response code 404 for https://play-fe.googleapis.com/fdfe/allowInAppReview?doc=...
2023-05-05 16:19:04.741  5845-6172  PlayCore                ...              I  UID: [10824]  PID: [5845] OnRequestInstallCallback : onGetLaunchReviewFlowInfo
2023-05-05 16:19:04.742  5845-6700  PlayCore                ...              I  UID: [10824]  PID: [5845] ReviewService : Unbind from service.
2023-05-05 16:19:04.782  5845-5845  RateApp                 ...              I  Request review flow finished
luk156 commented 1 year ago

+1

Nodonisko commented 1 year ago

Published https://github.com/Nodonisko/capacitor-rate-app/releases/tag/v4.0.0

AE1NS commented 1 year ago

I will bump it once I will have some feedback it actually works for Android. Did you tried it?

Thanks! So it will not be v5.0.0 from now on? :)

Nodonisko commented 1 year ago

@AE1NS I just removed beta tag, you can try version 4.0.3

AE1NS commented 1 year ago

I see, but what do you think about using the same major version number as capacitor core, as the capacitor team also do it. https://github.com/ionic-team/capacitor-plugins

For Capacitor 3, use the 1.x version of the plugins. For Capacitor 4, use the 4.x version of the plugins.

Starting with capacitor 4 they switched the versioning of the plugins to match the core version.

Its easier for developers to match the compatibility. But its up to you :)

Anyway, thanks for the update!