search

capacitor-community / native-market

MIT License
27 stars 16 forks source link

Compatibility with capacitor 3 #13

Closed hermitdemschoenenleben closed 1 year ago

hermitdemschoenenleben commented 2 years ago

this PR makes the native market plugin compatible with capacitor 3. I tested it on ios and android

(my fork is a fork of https://github.com/djonmayer/native-market that did most of the work!)

Mendzyy commented 2 years ago

Hello, @priyankpat

Bhai aa add karo ne please.

riderx commented 2 years ago

Good to me, can it be merge ?

riderx commented 2 years ago

i did publish this PR with the fix : https://github.com/riderx/native-market npm i native-market

hermitdemschoenenleben commented 2 years ago

I pushed a change that reverts the change in package url

riderx commented 2 years ago

@priyankpat can you have a look ? The fork is working in our app in ios and Android

adamvigneault commented 2 years ago

@priyankpat have you abandoned this project? Perhaps hand it over to @riderx?

petrot commented 1 year ago

Guys, any update on this PR? Using a forked version doesn't seem to be safe in our project..

raycarter commented 1 year ago

we have moved to @capgo/native-market. @petrot what is your security issue by using a fork?

petrot commented 1 year ago

@raycarter thanks for the quick answer :) It's not a real security issue, we just prefer using the official repos.

riderx commented 1 year ago

Hey @petrot I totally understand your point, I'm the maker behind Capgo. And I got very annoyed by the lack of maintain of some plugin even official, which is understandable, goal are not aligned between consumer and creator sometimes.

On my side, I have published 10 plugins and will continue to publish more, and keep them up to date. My business Capgo (a Capacitor OTA system), make this sustainable for me. Make open-source plugin and give to the community is my way of doing marketing for Capgo.

I'm creating also an open collective to make this sustainable for other plugin makers as well. That a good way to align interest of consumer and maker eventually :)

petrot commented 1 year ago

@riderx thanks for the detailed reply, it sounds good :)