search

capacitor-community / photoviewer

⚡ Capacitor plugin to view table images with fullscreen and sharing capabilities.
MIT License
54 stars 27 forks source link

change onTouch() method signature #32

Closed adnbrownie closed 1 year ago

adnbrownie commented 1 year ago

https://developer.android.com/reference/kotlin/android/view/View.OnTouchListener

-> missed one method in https://github.com/capacitor-community/photoviewer/pull/31

fixes https://github.com/capacitor-community/photoviewer/issues/30

jepiqueau commented 1 year ago

@adnbrownie in fact i merge it but it is wrong i could not build the project i got 

community/media/photoviewer/listeners/OnSwipeTouchListener.kt: (12, 34): Unexpected token
jepiqueau commented 1 year ago

@adnbrownie so i will do this

  override fun onTouch(view: View, motionEvent: MotionEvent): Boolean {
    return gestureDetector.onTouchEvent(motionEvent)
  }
adnbrownie commented 1 year ago

Ok sorry, I see now that the exclamation mark in Kotlin is not a language feature but just a notation for documentation etc.: https://kotlinlang.org/docs/java-interop.html#notation-for-platform-types

jepiqueau commented 1 year ago

@adnbrownie no problem.