Can you put some GIFs in the document

Lyfei commented 1 year ago

Convenient without having to run code to see the effect。

When I tried to use angular-photoviewer-app , Angular CLI required a different version of Node.js

When I adjusted CLI version in the demo, the build had another bug。

Error: Error on worker #1: Error: Debug Failure. Unhandled SyntaxKind: Unknown.

jepiqueau commented 1 year ago

@Lyfei can you provide more info which operating system which platform node version npm version and provide the package.json

Lyfei commented 1 year ago

@Lyfei can you provide more info which operating system which platform node version npm version and provide the package.json

I'm already up and running on iOS, using lower versions of angular.

Mac OS 12.6.3
Node v12.14.0

current package.json

{
  "dependencies": {
    "@angular/common": "12.2.17",
    "@angular/core": "12.2.17",
    "@angular/forms": "12.2.17",
    "@angular/platform-browser": "12.2.17",
    "@angular/platform-browser-dynamic": "12.2.17",
    "@angular/router": "12.2.17",
    "@capacitor-community/photoviewer": "^2.0.10",
    "@capacitor/android": "4.6.1",
    "@capacitor/app": "4.1.1",
    "@capacitor/core": "4.6.1",
    "@capacitor/haptics": "4.1.0",
    "@capacitor/ios": "4.6.1",
    "@capacitor/keyboard": "4.1.0",
    "@capacitor/status-bar": "4.1.1",
    "@capacitor/toast": "^4.1.0",
    "@ionic/angular": "^6.1.9",
    "@ionic/pwa-elements": "^3.1.1",
    "jeep-photoviewer": "^1.1.8",
    "rxjs": "~6.6.0",
    "tslib": "^2.2.0",
    "zone.js": "~0.11.4"
  },
  "devDependencies": {
    "@angular-devkit/build-angular": "12.2.17",
    "@angular-eslint/builder": "12.7.0",
    "@angular-eslint/eslint-plugin": "12.7.0",
    "@angular-eslint/eslint-plugin-template": "12.7.0",
    "@angular-eslint/template-parser": "12.7.0",
    "@angular/cli": "12.2.17",
    "@angular/compiler": "12.2.17",
    "@angular/compiler-cli": "12.2.17",
    "@angular/language-service": "12.2.17",
    "@capacitor/cli": "4.6.3",
    "@ionic/angular-toolkit": "latest",
    "@ionic/cli": "6.20.6",
    "@types/jasmine": "~3.6.0",
    "@types/jasminewd2": "~2.0.3",
    "@types/node": "^12.11.1",
    "@typescript-eslint/eslint-plugin": "4.16.1",
    "@typescript-eslint/parser": "4.16.1",
    "browserslist": "^4.21.5",
    "eslint": "^7.6.0",
    "eslint-plugin-import": "2.22.1",
    "eslint-plugin-jsdoc": "30.7.6",
    "eslint-plugin-prefer-arrow": "1.2.2",
    "jasmine-core": "~3.8.0",
    "jasmine-spec-reporter": "~5.0.0",
    "karma": "~6.3.2",
    "karma-chrome-launcher": "~3.1.0",
    "karma-coverage": "~2.0.3",
    "karma-coverage-istanbul-reporter": "~3.0.2",
    "karma-jasmine": "~4.0.0",
    "karma-jasmine-html-reporter": "^1.5.0",
    "protractor": "~7.0.0",
    "ts-node": "~8.3.0",
    "typescript": "~4.2.4"
  }
}

tsconfig.json

{
  "compileOnSave": false,
  "compilerOptions": {
    "baseUrl": "./",
    "outDir": "./dist/out-tsc",
    "sourceMap": true,
    "declaration": false,
    "downlevelIteration": true,
    "experimentalDecorators": true,
    "module": "esnext",
    "moduleResolution": "node",
    "importHelpers": true,
    "target": "es2015",
    "lib": [
      "es2018",
      "dom"
    ]
  },
  "angularCompilerOptions": {
    "fullTemplateTypeCheck": true,
    "strictInjectionParameters": true
  }
}

still recommend put some pictures of the effects on the App in the README.md

capacitor-community / photoviewer

Can you put some GIFs in the document #35