capacitor-community / photoviewer

PhotoViewer table images with fullscreen and sharing capabilities
MIT License
49 stars 12 forks source link

Close button stops working after device is rotated #50

Closed rkreutzer closed 9 months ago

rkreutzer commented 10 months ago

Describe the bug While displaying the viewer page, once the device is rotated, even if rotated back to the original position, the close function no longer works.

To Reproduce Steps to reproduce the behavior:

  1. Display a single image in the viewer
  2. Rotate the device
  3. Click the close icon

Expected behavior The close button and swipe-to-close should work in any device orientation.

Smartphone (please complete the following information):

jepiqueau commented 9 months ago

@rkreutzer recognized as a bug will look at it

jepiqueau commented 9 months ago

@rkreutzer Seems fixed in release 3.0.3 when it will be released can you test it and come back with your feedback

jepiqueau commented 9 months ago

@rkreutzer Is that fix now on your side?

rkreutzer commented 9 months ago

Still the same issue in 3.0.3

jepiqueau commented 9 months ago

@rkreutzer This has been reproduce so it will be fixed in the next release if you want to test it on your side now you comment this

  /*
      override fun onConfigurationChanged(newConfig: Configuration) {
         val view: View = initializeView()
          mContainer?.addView(view)

        super.onConfigurationChanged(newConfig)
    }

   */

in imageFragment and in mainFragment can you revert to me if it works.

rkreutzer commented 9 months ago

This fixes the issue. Thanks.

rkreutzer commented 8 months ago

This fix was not included in 3.0.3. I'm testing using 3.0.4 and it still has the issue.

camilocalvo commented 6 months ago

Same here, this is still broken on iOS. Please include this fix in the next release.