search

capacitor-community / react-hooks

⚡️ React hooks for Capacitor ⚡️
Other
249 stars 22 forks source link

Convert hooks to use the plugin specific packages in Capacitor v3. #21

Closed coreyjv closed 3 years ago

coreyjv commented 3 years ago

This PR for the most part was updating test mocks to be plugin package specific and changing from deprecated interfaces/methods/properties to the newly supported ones. I bumped the TypeScript version an tsconfig.json to match that of Capacitor v3.

chrisweight commented 3 years ago

anyone able to review / merge this? @mlynch / @liamdebeasi ?

StErMi commented 3 years ago

what's blocking this PR? Is there an "official" fork with this PR?

denisLoncaric commented 3 years ago

any updates on this PR?

denisLoncaric commented 3 years ago

@coreyjv maybe contact capacitor team on twitter as they suggested in README.md?

elylucas commented 3 years ago

Hi @coreyjv,

Thanks for this PR, however, we needed to take a different approach as this way will require to install all the Capacitor plugins even if you don't use them. This was something we got away from in Capacitor 3 by breaking out all the plugins into their own packages. We did the same with the React hooks, as each hook is now in its own package.