capacitor-community / sqlite

Community plugin for native & electron SQLite databases
MIT License
433 stars 106 forks source link

feat: add Capacitor 5 support #398

Closed robingenz closed 1 year ago

robingenz commented 1 year ago

Is your feature request related to a problem? Please describe.

This plugin does not yet support Capacitor 5.

Describe the solution you'd like

This plugin should support Capacitor 5.

Describe alternatives you've considered

Additional context

Migration Guide: https://capacitorjs.com/docs/next/updating/plugins/5-0

jepiqueau commented 1 year ago

@robingenz as far as i know Capacitor5 is not yet release and i do not have any glue of what will be the changes. Thanks for providing me the link for updating. Be patient.

jepiqueau commented 1 year ago

@robingenz i publish it as @capacitor-community/sqlite@next . Can you please test it and revert to me in case of issue.

robingenz commented 1 year ago

Thank you for your work! I plan to upgrade to Capacitor 5 in the next two weeks. I will get back to you as soon as possible.

tobiasmuecksch commented 1 year ago

Capacitor 5 is now officially released. The upgrade fails because sqlite depends on capacitor core 4.x.

See Cap 5 announcement: https://ionic.io/blog/announcing-capacitor-5

image
jepiqueau commented 1 year ago

@tobiasmuecksch look at the @next it is for capacitor 5

jepiqueau commented 1 year ago

@tobiasmuecksch it is a bêta but i test it 3 weeks ago and it was working fine

jepiqueau commented 1 year ago

@tobiasmuecksch can you try it and give le your feedback i am currently travelling

tobiasmuecksch commented 1 year ago

@jepiqueau Allright. Thanks. Will test it and let you know. Have a good trip 😊✌️

tobiasmuecksch commented 1 year ago

@jepiqueau The upgrade to Cap v5 seems to work. I haven't had time to test, if sqlite is working as expected yet. Will do soon.

jepiqueau commented 1 year ago

@tobiasmuecksch thanks, when you have done some tests please tell me. There were some changes mandatory in Android. So watch carefully to Android tests

jepiqueau commented 1 year ago

@tobiasmuecksch @robingenz i released 5.0.0-beta.2 which is based on @capacitor/core@5.0.0 and test it it works fine. Can you send please your feedback before i officially release 5.0.0.

tobiasmuecksch commented 1 year ago

@jepiqueau Yes, i will test it and give you feedback tomorrow.

robingenz commented 1 year ago

@jepiqueau Sorry, my team still hasn't updated the app to Capacitor 5.

Hobartchen commented 1 year ago

@jepiqueau Hi, I just downloaded the SQLite plugin by reference @next, and there's no error which is good. I still need to install the "vue-sqlite-hook" for my Ionic Vue project, which can't be installed since it's a Capacitor 5 project. Could you please provide any solution for that? Thanks.

jepiqueau commented 1 year ago

@Hobartchen you right the vue and react hooks have still to be updated to Capacitor5

Hobartchen commented 1 year ago

@Hobartchen you right the vue and react hooks have still to be updated to Capacitor5

Thanks @jepiqueau . Just waiting for your new release for vue hooks.

jepiqueau commented 1 year ago

@Hobartchen new release @next has been published

jepiqueau commented 1 year ago

@Hobartchen can you test it and give me your feedback

tobiasmuecksch commented 1 year ago

@jepiqueau I've tested the update and as far as I can tell, it works fine with ionic-angular and cap 5. Thank you 😄

Hobartchen commented 1 year ago

@Hobartchen can you test it and give me your feedback

Thanks, @jepiqueau, I got an error like the following. Could you please give me some clues on how to solve it? Many thanks! image image

jepiqueau commented 1 year ago

@Hobartchen you should be looking at vite-vue-sqlite-app how the main.ts file is written and adapt it to your case

jepiqueau commented 1 year ago

@tobiasmuecksch thank for your feedback it is greatly appreciate

tobiasmuecksch commented 1 year ago

@jepiqueau You're welcome. I've already deployed it to production for my android users. If any issues should come up, I'll let you know.